Re: bin/45356: make .SILENT doesn't work with "-j"

[Alan Barrett <apb%cequrux.com@localhost>]

On Sun, 11 Sep 2011, apb%cequrux.com@localhost wrote:
> > Description:
>         make(1)'s "-j" command line flag causes the ".SILENT" attribute
>         to be ignored for command lines that begin with "-".

This patch seems to fix it.  commandShell->errCheck is actually a
template for an "echo" command, and DBPRINTF is not just for debugging,
it also emits commands into a shell script that makewill invoke.  The
DBPRINTF in line 789 (just above the lines deleted by this patch) will
be used when make is not in silent mode, and the DBPRINTF in line 801
(deleted by this patch) was previously used in silent mode, but I think
it's not wanted.

Index: usr.bin/make/job.c
===================================================================
--- usr.bin/make/job.c  28 Aug 2011 03:54:07 -0000      1.159
+++ usr.bin/make/job.c  16 Sep 2011 19:22:33 -0000
@@ -796,10 +796,6 @@ JobPrintCommand(void *cmdp, void *jobp)
                        }
                        DBPRINTF(commandShell->errCheck, escCmd);
                        shutUp = TRUE;
-               } else {
-                       if (!shutUp) {
-                               DBPRINTF(commandShell->errCheck, escCmd);
-                       }
                }
                cmdTemplate = commandShell->ignErr;
                /*