Re: misc/45038: lack of tests options

[Julio Merino <jmmv%NetBSD.org@localhost>]

The following reply was made to PR misc/45038; it has been noted by GNATS.

From: Julio Merino <jmmv%NetBSD.org@localhost>
To: Nicolas Joly <njoly%pasteur.fr@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, misc-bug-people%netbsd.org@localhost, 
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
yamt%NetBSD.org@localhost
Subject: Re: misc/45038: lack of tests options
Date: Thu, 16 Jun 2011 16:01:12 +0100

 On 6/16/11 3:52 PM, Nicolas Joly wrote:
 > On Thu, Jun 16, 2011 at 02:44:21PM +0100, Julio M. Merino Vidal wrote:
 >> On 6/16/11 2:25 PM, Nicolas Joly wrote:
 >>>  Hi,
 >>>  
 >>>  Does the following patch fit your needs ?
 >>
 >> Looks nice!  Some minor comments:
 >>
 >>>  Index: share/man/man7/tests.7
 >>>  ===================================================================
 >>>  RCS file: /cvsroot/src/share/man/man7/tests.7,v
 >>>  retrieving revision 1.4
 >>>  diff -u -p -r1.4 tests.7
 >>>  --- share/man/man7/tests.7        7 Nov 2010 17:49:33 -0000       1.4
 >>>  +++ share/man/man7/tests.7        16 Jun 2011 13:19:28 -0000
 >>
 >> Don't forget to bump the date.
 > 
 > Will do. Thanks for the reminder.
 > 
 >>>  @@ -163,6 +163,16 @@ The suite-specific configuration file im
 >>>   which contains properties shared among all test suites.
 >>>   These files conform to the configuration file format described in
 >>>   .Xr atf-formats 5 .
 >>>  +.Pp
 >>>  +The following configuration variables are available in the
 >>>  +.Nx
 >>>  +test suite :
 >>>  +.Bl -tag -width "fstype"
 >>>  +.It fstype
 >>>  +When set to a filesystem type, restrict tests programs from the
 >>>  +.Pa /usr/tests/fs/vfs
 >>
 >> I'd add a trailing slash here to denote a directory.
 > 
 > Done.
 > 
 >>>  +tree to only run test cases for the given type.
 >>>  +.El
 >>
 >> Also document the unprivileged_user option.  It's used explicitly by
 >> some tests.  (It defaults to _atf.)
 > 
 > I don't find it anywhere. Is it "require.user" = "unprivileged" ? 
 
 Ah sorry, it's unprivileged-user.
 
 > IMHO, we should only document in tests(7) the configuration variables
 > which are not part of ATF.
 
 Well, I guess this one is a bit of a compromise.  unprivileged-user was
 _not_ an atf-specific variable; it used to be defined by NetBSD only.
 These days, it has a special meaning in atf itself, but some NetBSD
 tests query it directly to do their own stuff.  In other words, it is
 not only used by require.user=unprivileged, but also to perform some
 specific actions in the tmpfs tests.
 
 -- 
 Julio Merino / @jmmv