Re: misc/45038: lack of tests options

[Julio Merino <jmmv%NetBSD.org@localhost>]

On 6/16/11 2:25 PM, Nicolas Joly wrote:
>  Hi,
>  
>  Does the following patch fit your needs ?

Looks nice!  Some minor comments:

>  Index: share/man/man7/tests.7
>  ===================================================================
>  RCS file: /cvsroot/src/share/man/man7/tests.7,v
>  retrieving revision 1.4
>  diff -u -p -r1.4 tests.7
>  --- share/man/man7/tests.7   7 Nov 2010 17:49:33 -0000       1.4
>  +++ share/man/man7/tests.7   16 Jun 2011 13:19:28 -0000

Don't forget to bump the date.

>  @@ -163,6 +163,16 @@ The suite-specific configuration file im
>   which contains properties shared among all test suites.
>   These files conform to the configuration file format described in
>   .Xr atf-formats 5 .
>  +.Pp
>  +The following configuration variables are available in the
>  +.Nx
>  +test suite :
>  +.Bl -tag -width "fstype"
>  +.It fstype
>  +When set to a filesystem type, restrict tests programs from the
>  +.Pa /usr/tests/fs/vfs

I'd add a trailing slash here to denote a directory.

>  +tree to only run test cases for the given type.
>  +.El

Also document the unprivileged_user option.  It's used explicitly by
some tests.  (It defaults to _atf.)

>   .Ss What to do if something fails?
>   If there is
>   .Em any failure

Lastly, it may be worth to note that these settings go into
/etc/atf/NetBSD.conf .  Not sure if this is already mentioned in the
manpage.

-- 
Julio Merino / @jmmv