Re: lib/44959: Missing closedir in glob.c

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR lib/44959; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: henning.petersen%t-online.de@localhost, christos%NetBSD.org@localhost
Subject: Re: lib/44959: Missing closedir in glob.c
Date: Sat, 14 May 2011 23:31:23 +0200

 On Fri, May 13, 2011 at 09:45:02AM +0000, henning petersen wrote:
 >  Is this OK.
 
 I think it is, but I do not understand the comment below the loop:
 
  * Again Posix X/Open issue with regards to error handling.
 
 and maybe we should return "error" in this case, like:
 
         if ((error || errno) && (pglob->gl_flags & GLOB_ERR))
                 return error ? error : GLOB_ABORTED;
 
 
 Christos, could you review? Or anyone?
 
 Martin