toolchain/44834: Building on Solaris, sh problem: empty for loop

[nakaji%jp.freebsd.org@localhost]

>Number:         44834
>Category:       toolchain
>Synopsis:       Building on Solaris, sh problem: empty for loop
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 06 06:00:00 +0000 2011
>Originator:     NAKAJI Hiroyuki
>Release:        Oracle Solaris 11 Express snv_151a X86
>Organization:
>Environment:
SunOS sayaka 5.11 snv_151a i86pc i386 i86pc Solaris
>Description:
From the output of build.sh command:

#    create  libposix/Atffile
/usr/xpg4/bin/sh: syntax error at line 1 : `;' unexpected

*** Failed target:  Atffile
*** Failed command: { echo 'Content-Type: application/X-atf-atffile; 
version="1"'; echo; echo '# Automatically generated by bsd.test.mk.'; echo; 
echo 'prop: test-suite = "NetBSD"'; echo; for tp in ; do echo "tp: ${tp}"; 
done; } >Atffile.tmp
*** Error code 2

Stop.
nbmake: stopped in /home/nakaji/NetBSD/src/tests/lib/libposix

*** Failed target:  dependall
*** Failed command: cd "/home/nakaji/NetBSD/src/tests/lib/libposix"; 
home/nakaji/NetBSD/obj/tooldir.SunOS-5.11-i86pc/bin/nbmake realall

>How-To-Repeat:
% cvs co -P src
% cd src
% ./build.sh -m amd64 (or any) ...

>Fix:
As described in the current-users thread, 
http://mail-index.netbsd.org/current-users/2008/11/28/msg006344.html, 
share/mk/bsd.test.mk needs change. For example,

Index: bsd.test.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.test.mk,v
retrieving revision 1.17
diff -u -r1.17 bsd.test.mk
--- bsd.test.mk 27 Mar 2011 14:22:02 -0000      1.17
+++ bsd.test.mk 6 Apr 2011 05:58:31 -0000
@@ -72,7 +72,8 @@
        echo; \
        echo 'prop: test-suite = "NetBSD"'; \
        echo; \
-       for tp in ${_TESTS}; do \
+       tests=${_TESTS:Q}; \
+       for tp in $$tests; do \
            echo "tp: $${tp}"; \
        done; } >Atffile.tmp
        @mv Atffile.tmp Atffile