NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/43570: Avoid multiple interrupt routing lists for a bus

The following reply was made to PR kern/43570; it has been noted by GNATS.

From: Paul Goyette <>
To: Jukka Ruohonen <>
Subject: Re: kern/43570: Avoid multiple interrupt routing lists for a bus
Date: Tue, 5 Apr 2011 05:58:24 -0700 (PDT)

 On Tue, 5 Apr 2011, Jukka Ruohonen wrote:
 > On Tue, Apr 05, 2011 at 04:38:43AM -0700, Paul Goyette wrote:
 >> Just wondering if anyone has had any futher thoughts on what additional
 >> action, if any, is needed on this PR?
 > As you wrote, this does not seem like the right thing to do. It always
 > choses, more or less arbitrarily, the first routing information. That is,
 > the idea is right, but the fix should be done much earlier, when scanning
 > for the buses.
 Gregoire's patch seems to have fixed the underlying cause of the 
 specific problem with the SuperMicro motherboard.  But I'm more 
 interested in in your additional comment in the PR, about displaying 
 some sort of warning that the duplication exists:
        The earlier patch from Paul should probably go in as well, at
        least to print a warning if the code tries to overwrite
 In other words, something like this:
 +      if (mpb->mb_name != NULL)
 +              aprint_error("mpacpi: PCI bus %d int routing already done!\n",
 +                  mpr->mpr_bus);
 If we don't think that this is useful or appropriate, maybe we should 
 just close the PR?
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
 | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at    |
 | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
 | Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index