Re: kern/44288: tmpfs_rmdir() panic

[Jukka Ruohonen <jruohonen%iki.fi@localhost>]

The following reply was made to PR kern/44288; it has been noted by GNATS.

From: Jukka Ruohonen <jruohonen%iki.fi@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Taylor R Campbell <campbell%mumble.net@localhost>,
        David Holland <dholland-bugs%NetBSD.org@localhost>,
        Antti Kantee <pooka%cs.hut.fi@localhost>
Subject: Re: kern/44288: tmpfs_rmdir() panic
Date: Sat, 19 Mar 2011 22:03:37 +0200

 On Mon, Feb 28, 2011 at 07:00:07PM +0000, Taylor R Campbell wrote:
 >  I just tested the patch with rump.  Without the patch, the link count
 >  was wrong, and rmdiring test/bar and then test made rump_tmpfs crash
 >  on the same KASSERT as jruoho observed.  With the patch, the link
 >  count is right, and rmdiring test/bar and then test works dandily.
 
 I am sorry to inform, but the assertion still goes off with this patch
 
  +              /* If we just detached a directory, decrement the
  +               * parent's link count, since the to-node's .. will no
  +               * longer point to it.  */
  +              if (tnode->tn_type == VDIR)
  +                      tdnode->tn_links--;
  +
 
 The frequency of it has also increased in real-world usage, given that it is
 now triggered by several other pkgsrc packages as well.
 
 - Jukka.