Re: kern/44625: memory exhaustion on NFS server while writing many files

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/44625; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/44625: memory exhaustion on NFS server while writing many
 files
Date: Sat, 19 Mar 2011 01:43:00 +0000

 On Thu, Mar 17, 2011 at 10:50:07AM +0000, hash%abox3.so-net.ne.jp@localhost 
wrote:
  >  >  This may help (not tested yet though):
  >  
  >  I try to rsync x4 and currently it does not seem to leak.
 
 Good...
 
  >  BTW does it need to check whether nd.ni_pathbuf != NULL
  >  at 6 lines below?
 
 Yes - it's an error branch for more than one error case. If nfs_namei
 succeeds and then the webnfs goop fails, the pathbuf will need to be
 destroyed. However, if nfs_namei fails the pathbuf should be null.
 
 There's another bug though, which is that nfs_namei shouldn't ever be
 sending back a non-null path buffer if it fails, which it apparently
 does in some circumstances since I assume you weren't using webnfs.
 Will attend to that tomorrow.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost