Re: kern/44652: 'gpt destroy' panics

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

On 02.03.11 12:15, Christoph Egger wrote:
> The following reply was made to PR kern/44652; it has been noted by GNATS.
> 
> From: Christoph Egger <Christoph_Egger%gmx.de@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: Hauke Fath <hf%spg.tu-darmstadt.de@localhost>, 
> kern-bug-people%netbsd.org@localhost, 
>  gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
> Subject: Re: kern/44652: 'gpt destroy' panics
> Date: Wed, 02 Mar 2011 12:07:32 +0100
> 
>  On 03/02/11 11:45, Hauke Fath wrote:
>  > The following reply was made to PR kern/44652; it has been noted by GNATS.
>  >
>  > From: Hauke Fath<hf%spg.tu-darmstadt.de@localhost>
>  > To: gnats-bugs%NetBSD.org@localhost
>  > Cc: kern-bug-people%NetBSD.org@localhost
>  > Subject: Re: kern/44652: 'gpt destroy' panics
>  > Date: Wed, 2 Mar 2011 11:41:57 +0100
>  >
>  >   At 10:00 Uhr +0000 01.03.2011, Hauke Fath wrote:
>  >   >  I deconstructed wedges and gpts of the above installation in the right
>  >   >  sequence, dd(1)ed the beginning of the disk, and ten seconds or so 
> later
>  >   >  was hit with
>  >   >  
> <http://la.causeuse.org/hauke/NetBSD/gpt-issues/gpt_destroy_raid_panic.jpg>.
>  >
>  >   And another one
>  >
>  >   <http://la.causeuse.org/hauke/NetBSD/gpt-issues/gpt_raidframe_panic.jpg>
>  >
>  >   which I got while deconstructing wedges and partitions out of order. As
>  >   Christoph pointed out, another null pointer issue; not sc though, which 
> is
>  >   checked in the caller dkstrategy().
>  
>  This time the crash happens in sys/dev/dkwedge/dk.c, line 1200:
>  
>         nbp->b_dev = sc->sc_parent->dk_rawvp->v_rdev;
>  
>  dk_rawvp is NULL.

Please update said file from cvs and retry.

--------------------------------------------------
Module Name:    src
Committed By:   christos
Date:           Thu Mar  3 03:39:08 UTC 2011

Modified Files:
        src/sys/dev/dkwedge: dk.c

Log Message:
check rawvp before doing ioctl or strategy.


To generate a diff of this commit:
cvs rdiff -u -r1.59 -r1.60 src/sys/dev/dkwedge/dk.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
--------------------------------------------------

Christoph