lib/44663: Common typo in src/lib/libm/complex/cproj.c, cprojf.c, cprojl.c

[vinschen%redhat.com@localhost]

>Number:         44663
>Category:       lib
>Synopsis:       Common typo in src/lib/libm/complex/cproj.c, cprojf.c, cprojl.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 02 09:10:00 +0000 2011
>Originator:     Corinna Vinschen
>Release:        None
>Organization:
Red Hat
>Environment:
N/A
>Description:
The libc/libm implementation Newlib imported the complex functions
from NetBSD lately.  Now somebody on the newlib mailing list found
a typo in the cproj functions.  A parenthesis has been set incorrectly:

  if (isinf(creal(z) || isinf(cimag(z))))

The first isinf call is not closed before the ||, rather the second
isinf is or'ed with `creal(z)' instead.  This should be

  if (isinf(creal(z)) || isinf(cimag(z)))

This occurs in all three cproj implementations, in cproj.c,
cprojf.c, and cprojl.c.
 

Hope that helps,
Corinna
>How-To-Repeat:

>Fix: