kern/44649: TASET_IPSEC failes to increment ESP-output statistic correctly

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         44649
>Category:       kern
>Synopsis:       TASET_IPSEC failes to increment ESP-output statistic correctly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 28 10:55:00 +0000 2011
>Originator:     Dr. W. Stukenbrock
>Release:        NetBSD 5.1
>Organization:
Dr. Nagler & Company GmbH
>Environment:
        
        
System: NetBSD e400 5.1 NetBSD 5.1 (NSW-locationGW) #21: Wed Feb 16 13:18:19 
CET 2011  
wgstuken@s012:/export/NetBSD-5.1/N+C-build/.OBJDIR_amd64/export/NetBSD-5.1/src/sys/arch/amd64/compile/NSW-locationGW
 amd64
Architecture: x86_64
Machine: amd64
>Description:
        The statistic for ESP-output bytes is acceently added to the number of 
ESP output packets.
        This results in a very high number of output packets and a number of 0 
ouput bytes.
>How-To-Repeat:
        setup FAST-IPSEC and an ESP connection and look at the statistics with 
"netstat -p ipsec".
>Fix:
        The problem is a wrong MACRO used in /usr/src/sys/netipsec/xform_esp.c.
        The following patch will fix this problem.

--- xform_esp.c 2011/02/11 14:06:19     1.4
+++ xform_esp.c 2011/02/28 10:45:44
@@ -775,7 +775,7 @@
        }
 
        /* Update the counters. */
-       ESP_STATADD(ESP_STAT_OUTPUT, m->m_pkthdr.len - skip);
+       ESP_STATADD(ESP_STAT_OBYTES, m->m_pkthdr.len - skip);
 
        m = m_clone(m);
        if (m == NULL) {

>Unformatted: