Re: kern/44630: rgephy(4) likes auto-negotiation too much

[River Tarnell <r.tarnell%IEEE.ORG@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Laight:
>  > rgephy(4) enables auto-negotiation even when the user explicitly
>  > specifies a media type.  This is unfortunate, because if the switch is
>  > forced to 100-FD, the card will fail to negotiate and fall back to
>  > 100-HD.  The duplex mismatch makes it so slow as to be unusable.
  
>  Does setting the PHYs autonegotiate advertise register (ANAR)
>  to the required mode help?

Isn't this already done when 'ifconfig re0 media 100basetx' is 
specified?

                case IFM_100_TX:
                        speed = RGEPHY_S100;
                        anar |= RGEPHY_ANAR_TX_FD | RGEPHY_ANAR_TX;

ANAR_TX is later removed by 'mediaopt full-duplex':

                        if ((ife->ifm_media & IFM_GMASK) == IFM_FDX) {
                                speed |= RGEPHY_BMCR_FDX;
                                gig = RGEPHY_1000CTL_AFD;
                                anar &= ~(RGEPHY_ANAR_TX | RGEPHY_ANAR_10);

... which leaves anar = RGEPHY_ANAR_TX_FD (100Base-TX).

>  IMHO that should be done instead of forcing the actual mode.

In this particular case I believe this is the right solution, because 
the switch is forced to 100-FD, i.e. auto-negotiation is disabled.

        - river.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (NetBSD)

iEYEARECAAYFAk1mECIACgkQIXd7fCuc5vLPVgCeMR48UIFok58K1aJA4Z9LacaH
iMYAn2SV0pJNTiDbVRePUL/cjkC2c0LO
=hY49
-----END PGP SIGNATURE-----