Re: PR/44210 CVS commit: src/sys/opencrypto

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

Hi, now I've had a look at it.

The patch looks good, it seems to address the problems.
I've no way to validate it by running it at the moment, but I think you 
have done it.
The "look into the sources" doesn't show any wrong things to me.

Perhaps a DPRINTF() should be added around line 437 if the packet is 
dropped due to bad size and/or crc-data. There are DPRINTF() in all 
other error cases ...

I think you can close this report.

best regards

W. Stukenbrock

Wolfgang Stukenbrock wrote:

> The following reply was made to PR kern/44210; it has been noted by GNATS.
>
> From: Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: 
> Subject: Re: PR/44210 CVS commit: src/sys/opencrypto
> Date: Fri, 18 Feb 2011 12:59:42 +0100
>
>  Hallo - nur vorab ein Lebenszeichen - daher auch nur an Dich.
>  
>  Ich werde erst nächste Woche dazu kommen es anzusehen.
>  
>  Gruß
>  
>  W. Stukenbrock
>  
>  Matthias Drochner wrote:
>  
>  > The following reply was made to PR kern/44210; it has been noted by GNATS.
>  > 
>  > From: "Matthias Drochner" <drochner%netbsd.org@localhost>
>  > To: gnats-bugs%gnats.NetBSD.org@localhost
>  > Cc: 
>  > Subject: PR/44210 CVS commit: src/sys/opencrypto
>  > Date: Fri, 18 Feb 2011 10:50:57 +0000
>  > 
>  >  Module Name:	src
>  >  Committed By:    drochner
>  >  Date:            Fri Feb 18 10:50:57 UTC 2011
>  >  
>  >  Modified Files:
>  >   src/sys/opencrypto: deflate.c
>  >  
>  >  Log Message:
>  >  address the obvious byteorder and alignment problems in gzip size/crc
>  >  tail, should fix PR kern/44210 by Wolfgang Stukenbrock
>  >  being here, fix a bug in crc calculation of decompressed data, and
>  >  actually verify the crc
>  >  
>  >  
>  >  To generate a diff of this commit:
>  >  cvs rdiff -u -r1.16 -r1.17 src/sys/opencrypto/deflate.c
>  >  
>  >  Please note that diffs are not public domain; they are subject to the
>  >  copyright notices on the relevant files.
>  >  
>  > 
>  
>  


--


Dr. Nagler & Company GmbH
Hauptstraße 9
92253 Schnaittenbach

Tel. +49 9622/71 97-42
Fax +49 9622/71 97-50

Wolfgang.Stukenbrock%nagler-company.com@localhost
http://www.nagler-company.com


Hauptsitz: Schnaittenbach
Handelregister: Amberg HRB
Gerichtsstand: Amberg
Steuernummer: 201/118/51825
USt.-ID-Nummer: DE 273143997
Geschäftsführer: Dr. Martin Nagler, Dr. Dr. Karl-Kuno Kunze