Re: port-i386/44581: MacBook1,1 won't resume after suspend

[Taylor R Campbell <campbell+netbsd%mumble.net@localhost>]

The following reply was made to PR port-i386/44581; it has been noted by GNATS.

From: Taylor R Campbell <campbell+netbsd%mumble.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-i386/44581: MacBook1,1 won't resume after suspend
Date: Thu, 17 Feb 2011 00:12:01 +0000

    Date: Wed, 16 Feb 2011 20:19:10 +0000
    From: Taylor R Campbell <campbell+netbsd%mumble.net@localhost>
 
    I tried the following patch, and, lo and behold, the machine resumes!
    (I have lots of changes in this tree which may be necessary too.)
 
 Oops -- this was a red herring.  In my testing of dozens of different
 configurations, I must have mixed some of them up.  If I undo this
 patch, it also works, so it must be the SCI business that let Firewire
 resumption work.  So I think this PR can be closed now, unless someone
 is interested in applying one of the earlier patches I sent to make
 reattaching fwohci0 merely fail and not panic after suspending and
 resuming.
 
 I also tested removing the calls in firewire.c to config_pending_incr
 and config_pending_decr -- I don't see why they're there, I observed a
 panic because of a race condition between them, and the code seems to
 work without them.  At the very least, I think the calls to
 kthread_create and config_pending_incr should be reversed, like they
 were when the code was imported.