Re: port-i386/44563: boot loader prompt doesn't read keyboard input on a MacBook1,1

[David Laight <david%l8s.co.uk@localhost>]

The following reply was made to PR port-i386/44563; it has been noted by GNATS.

From: David Laight <david%l8s.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-i386/44563: boot loader prompt doesn't read keyboard input on 
a MacBook1,1
Date: Tue, 15 Feb 2011 08:23:18 +0000

 On Mon, Feb 14, 2011 at 11:20:04PM +0000, Taylor R Campbell wrote:
 >  
 >  Index: pcio.c
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/arch/i386/stand/lib/pcio.c,v
 >  retrieving revision 1.23.8.2
 >  diff -p -u -r1.23.8.2 pcio.c
 >  --- pcio.c  28 Nov 2009 15:40:47 -0000      1.23.8.2
 >  +++ pcio.c  14 Feb 2011 23:16:12 -0000
 >  @@ -265,6 +265,8 @@ getchar(void)
 >      default: /* to make gcc -Wall happy... */
 >      case CONSDEV_PC:
 >   #endif
 >  +           while (!coniskey())
 >  +                   continue;
 >              c = congetc();
 
 Hmmm... This shouldn't be needed, I can't remember if the bios call
 congetc() does is expected to block or return -1 (or similar) to
 indicate 'nothing available'.
 
 In any case it is worth checking what the mbr code does.
 Perhaps we should just directly read the ps2 keyboard uart!
 
        David
 
 -- 
 David Laight: david%l8s.co.uk@localhost