Re: PR/44523 CVS commit: src/sys/fs/hfs

[Taylor R Campbell <campbell+netbsd%mumble.net@localhost>]

The following reply was made to PR kern/44523; it has been noted by GNATS.

From: Taylor R Campbell <campbell+netbsd%mumble.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
netbsd-bugs%netbsd.org@localhost,
        christos%netbsd.org@localhost
Subject: Re: PR/44523 CVS commit: src/sys/fs/hfs
Date: Thu, 10 Feb 2011 03:16:17 +0000

    Date: Thu, 10 Feb 2011 01:50:05 +0000 (UTC)
    From: "Christos Zoulas" <christos%netbsd.org@localhost>
 
    PR/44523: Taylor R Campbell: mount_hfs badly handles file names with sla=
 shes
    in them, encode them as colons. XXX: Should encode : as :: too?
 
 No, I don't think that's worth the trouble: as far as I know, the
 on-disk format is not supposed to have colons in file names, whereas
 it is supposed to be able to have slashes in file names, because the
 old Macintosh pathname syntax used colons rather than slashes as
 separators.
 
    +           /* XXX: perhaps check for colons too, and encode them? */
    +           for (ni =3D 0; ni < len; ni++)
    +                   if (unicn[ni] =3D=3D (unichar_t)'/')
    +                           unicn[ni] =3D (unichar_t)':';
 
 Oops -- I got this backwards in the patch I submitted.  (I must have
 tweaked the patch after testing it and before sending it.)  This
 fragment in hfs_vop_lookup should replace colon by slash, not the
 other way around.