bin/44326: Missing format string in fwctl.

[henning.petersen%t-online.de@localhost]

>Number:         44326
>Category:       bin
>Synopsis:       Missing format string in fwctl.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 04 07:50:00 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Missing format string in fwctl.
>How-To-Repeat:

>Fix:
diff -u -r1.4 fwdv.c
--- usr.sbin/fwctl/fwdv.c       24 Aug 2010 08:41:24 -0000      1.4
+++ usr.sbin/fwctl/fwdv.c       4 Jan 2011 06:23:39 -0000
@@ -107,7 +107,7 @@
        } else {
                fd = open(filename, O_CREAT | O_WRONLY | O_TRUNC, 0660);
                if (fd == -1)
-                       err(EX_NOINPUT, filename);
+                       err(EX_NOINPUT, "%s", filename);
        }
        buf = malloc(RBUFSIZE);
        pad = malloc(DSIZE*MAXBLOCKS);
@@ -269,7 +269,7 @@
 
        fd = open(filename, O_RDONLY);
        if (fd == -1)
-               err(EX_NOINPUT, filename);
+               err(EX_NOINPUT, "%s", filename);
 
        pbuf = malloc(DSIZE * TNBUF);
        bzero(wbuf, sizeof(wbuf));

diff -u -r1.2 fwmpegts.c
--- usr.sbin/fwctl/fwmpegts.c   24 Aug 2010 08:41:24 -0000      1.2
+++ usr.sbin/fwctl/fwmpegts.c   4 Jan 2011 06:23:39 -0000
@@ -156,7 +156,7 @@
        else {
                fd = open(filename, O_CREAT | O_WRONLY | O_TRUNC, 0660);
                if (fd == -1)
-                       err(EX_NOINPUT, filename);
+                       err(EX_NOINPUT, "%s", filename);
        }
        buf = malloc(RBUFSIZE);