Re: kern/44144 (ifconfig causes assertion failure in vfs_lookup.c)

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR kern/44144; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/44144 (ifconfig causes assertion failure in vfs_lookup.c)
Date: Sun, 26 Dec 2010 22:39:54 +0200

 On Sun, 26 Dec 2010, David Holland wrote:
 >   >  # ifconfig wpi0 up
 >   >  wpi0: ERROR: could not read firmware file
 >   >  wpi0: ERROR: could not load firmware file
 >   >  wpi0: cannot assign link-local address
 >   >  wpi0: ERROR: could not read firmware file
 >   >  wpi0: ERROR: could not load firmware file
 >   >  wpi0: ERROR: could not read firmware file
 >   >  wpi0: ERROR: could not load firmware file
 >   >  wpi0: cannot assign link-local address
 >   >  #
 >   >  
 >   >  There's no panic, which is good, but I think that the first error should
 >   >  have been handled in such a way that the other errors did not occur.
 >  
 >  Yeah, but that will take some restructuring; as things are it's going
 >  to attempt wpi_cache_firmware every time it goes through wpi_init
 >  until it succeeds, and each successive call is going to print a
 >  message.
 
 I guess I expected the first failure to cause an error to be returned to
 userland.  If I run "ifconfig wpi0 up" again, then it would be fine if
 it printed another error message, but preferably only one each time.
 
 >  This patch should cover more of the bases. (But note that I don't have
 >  one of these, so I haven't tested it at all...)
 
 Thank you; I'll try it tomorrow.
 
 --apb (Alan Barrett)