Re: kern/44144 (ifconfig causes assertion failure in vfs_lookup.c)

[Alan Barrett <apb%cequrux.com@localhost>]

On Sun, 26 Dec 2010, Alan Barrett wrote:
>  I applied that patch, and now I get this:
>  
>  # ifconfig wpi0 up
>  wpi0: ERROR: could not read firmware file
>  panic: free: addr 0x0 not within kmem_map

If I guard the firmware_free() call after label fail1 at the end of
the wpi_cache_firmware() function with "if (wpi_firmware_imaeg != NULL)"
then I get this:

# ifconfig wpi0 up
wpi0: ERROR: could not read firmware file
wpi0: ERROR: could not load firmware file
wpi0: cannot assign link-local address
wpi0: ERROR: could not read firmware file
wpi0: ERROR: could not load firmware file
wpi0: ERROR: could not read firmware file
wpi0: ERROR: could not load firmware file
wpi0: cannot assign link-local address
#

There's no panic, which is good, but I think that the first error should
have been handled in such a way that the other errors did not occur.
It would also be nice if the "could not read firmware file" message
included the file name.

--apb (Alan Barrett)