Re: install/44226: Vax bootloader doesn't support FFSv2

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR install/44226; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: install-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost,
        mm_lists%pulsar-zone.net@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: install/44226: Vax bootloader doesn't support FFSv2
Date: Sat, 18 Dec 2010 14:43:04 +0900

 >  Should this really be worth a pullup to NetBSD-5 though?
 
 It's possbile, but there are too many changes and
 we have to check which revisions are actually required
 and whether they cause conflicts...
 
 >  ran NetBSD/vax in SIMH so far, I didn't really need the advantages of
 >  FFS2, although I was bitten once by an install where I selected it.  It
 >  also would be fine for me if it only was clearly documented that the
 >  NetBSD-5/vax bootloader doesn't support booting from FFSv2 file systems.
 
 Adding FFSv2 support to vax bootloader is fairly easy
 though the primary xxboot grows almost ~7.5KB size restriction...
 (prepare optional xxboot_ffsv2 like i386?)
 
 
 Index: boot/conf.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/vax/boot/boot/conf.c,v
 retrieving revision 1.15
 diff -u -p -r1.15 conf.c
 --- boot/conf.c        18 Mar 2009 16:00:15 -0000      1.15
 +++ boot/conf.c        18 Dec 2010 05:32:41 -0000
 @@ -88,7 +88,8 @@ int  cnvtab[] = {
  int     ndevs = (sizeof(devsw)/sizeof(devsw[0]));
  
  struct fs_ops file_system[] = {
 -      FS_OPS(ufs),
 +      FS_OPS(ffsv1),
 +      FS_OPS(ffsv2),
        FS_OPS(nfs),
        FS_OPS(cd9660),
        FS_OPS(ustarfs),
 Index: xxboot/Makefile
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/vax/boot/xxboot/Makefile,v
 retrieving revision 1.21
 diff -u -p -r1.21 Makefile
 --- xxboot/Makefile    11 Dec 2005 12:19:34 -0000      1.21
 +++ xxboot/Makefile    18 Dec 2010 05:32:42 -0000
 @@ -19,6 +19,7 @@ CPPFLAGS+=-D_STANDALONE -DLIBSA_NO_FD_CH
        -DLIBSA_NO_FS_SYMLINK -DLIBSA_NO_FS_CLOSE \
        -DLIBSA_NO_FS_WRITE -DLIBSA_NO_FS_SEEK \
        -DNEED_UFS -DNEED_CD9660
 +CPPFLAGS+=-DNEED_FFSv2
  # Use small daddr_t to avoid code bloat
  CPPFLAGS+=-D__daddr_t=int32_t
  BINDIR=       /usr/mdec
 Index: xxboot/bootxx.c
 ===================================================================
 RCS file: /cvsroot/src/sys/arch/vax/boot/xxboot/bootxx.c,v
 retrieving revision 1.36
 diff -u -p -r1.36 bootxx.c
 --- xxboot/bootxx.c    18 Sep 2009 21:40:09 -0000      1.36
 +++ xxboot/bootxx.c    18 Dec 2010 05:32:42 -0000
 @@ -186,7 +186,10 @@ die:
   */
  struct fs_ops file_system[] = {
  #ifdef NEED_UFS
 -      { ufs_open, 0, ufs_read, 0, 0, ufs_stat },
 +      { ffsv1_open, 0, ffsv1_read, 0, 0, ffsv1_stat },
 +#endif
 +#ifdef NEED_FFSv2
 +      { ffsv2_open, 0, ffsv2_read, 0, 0, ffsv2_stat },
  #endif
  #ifdef NEED_CD9660
        { cd9660_open, 0, cd9660_read, 0, 0, cd9660_stat },
 
 ---
 
 % ls -l xxboot/obj.vax/xxboot
 -rwxr-xr-x  1 tsutsui  wheel  7600 Dec 18 14:29 xxboot/obj.vax/xxboot
 
 ---
 Izumi Tsutsui