bin/44185: sort doesn't work correctly under -r option for sorting a file including HT(0x09) and VT(0x0b)

[anycmd%mamemilk.com@localhost]

>Number:         44185
>Category:       bin
>Synopsis:       sort doesn't work correctly under -r option for sorting a file 
>including HT(0x09) and VT(0x0b)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 02 14:45:00 +0000 2010
>Originator:     Hiro Aki
>Release:        
>Organization:
Any Command Reading Club
>Environment:
>Description:
using sort (bsdsort 1.0) with -r option, the file isn't sorted correctly that 
contains HT(0x09) and VT(0x0b).

for example 

like this file, samp.txt
  $ cat > samp.txt
  [TAB]bbb
  ^Kaaa
  ^D$ od -a samp.txt
  0000000   ht   b   b   b  nl  vt   a   a   a  nl
  0000012
  $ cat samp.txt
         bbb

  aaa


the result of sort -r should be this,
  
  aaa
         bbb

but the result of the bsdsort -r is this,
         bbb
  
  aaa



>How-To-Repeat:
looks like this problem is caused by the misconfiguration of weight table. 

output u_char gweights[256] which is initialized in settables() is below. 

* without -r option
 |  00  01  02  03  04  05  06  07  08  09  0a  0b  0c  0d  0e  0f
--+-----------------------------------------------------------------
00|   1   2   3   4   5   6   7   8   9  10   0  11  12  13  14  15
10|  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31
20|  32  33  34  35  36  37  38  39  40  41  42  43  44  45  46  47
30|  48  49  50  51  52  53  54  55  56  57  58  59  60  61  62  63
40|  64  65  66  67  68  69  70  71  72  73  74  75  76  77  78  79
50|  80  81  82  83  84  85  86  87  88  89  90  91  92  93  94  95
60|  96  97  98  99 100 101 102 103 104 105 106 107 108 109 110 111
70| 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
80| 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
90| 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
a0| 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
b0| 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191
c0| 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207
d0| 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
e0| 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
f0| 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255

* with -r option
 |  00  01  02  03  04  05  06  07  08  09  0a  0b  0c  0d  0e  0f
--+-----------------------------------------------------------------
00| 254 253 252 251 250 249 248 247 246 245 255 245 244 243 242 241
10| 240 239 238 237 236 235 234 233 232 231 230 229 228 227 226 225
20| 224 223 222 221 220 219 218 217 216 215 214 213 212 211 210 209
30| 208 207 206 205 204 203 202 201 200 199 198 197 196 195 194 193
40| 192 191 190 189 188 187 186 185 184 183 182 181 180 179 178 177
50| 176 175 174 173 172 171 170 169 168 167 166 165 164 163 162 161
60| 160 159 158 157 156 155 154 153 152 151 150 149 148 147 146 145
70| 144 143 142 141 140 139 138 137 136 135 134 133 132 131 130 129
80| 128 127 126 125 124 123 122 121 120 119 118 117 116 115 114 113
90| 112 111 110 109 108 107 106 105 104 103 102 101 100  99  98  97
a0|  96  95  94  93  92  91  90  89  88  87  86  85  84  83  82  81
b0|  80  79  78  77  76  75  74  73  72  71  70  69  68  67  66  65
c0|  64  63  62  61  60  59  58  57  56  55  54  53  52  51  50  49
d0|  48  47  46  45  44  43  42  41  40  39  38  37  36  35  34  33
e0|  32  31  30  29  28  27  26  25  24  23  22  21  20  19  18  17
f0|  16  15  14  13  12  11   9   8   7   6   5   4   3   2   1   0


without -r option, no doubled weights are found, but with -r option these 
weight are doubled. 

0x09: 245
0x0b: 245
>Fix:
to fix the problem, modify the settables()

345:    for (i = 0; i < REC_D; i++)
->          
345:    for (i = 0; i < (REC_D * incr & 255); i++)

but we don't know if this modification affect some other parts. so we would 
like to ask the developer to check the problem.