kern/44094: proplib has redundant locking

[rmind%netbsd.org@localhost]

>Number:         44094
>Category:       kern
>Synopsis:       proplib has redundant locking
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 15 15:40:00 +0000 2010
>Originator:     Mindaugas Rasiukevicius
>Release:        NetBSD 5.99.39
>Organization:
The NetBSD Project
>Environment:
>Description:
        proplib(3) has internal locking and is MP-safe.  However, typical
        user of interface either (a) uses it in a single-threaded manner
        (b) needs to perform its own synchronisation and therefore provide
        locking at upper, caller's level.

        Note that interface parts which might block (e.g. allocate memory)
        should be documented for consideration of locking strategy and/or
        determinism.
>How-To-Repeat:
        Code inspection.
>Fix:
        Consider removal of locking from proplib(3).