RE: kern/43958: Can't compile Atari kernel with ksyms pseudo-device enabled

[David Ross <dross%pobox.com@localhost>]

The following reply was made to PR kern/43958; it has been noted by GNATS.

From: David Ross <dross%pobox.com@localhost>
To: <gnats-bugs%netbsd.org@localhost>, <kern-bug-people%netbsd.org@localhost>,
        <gnats-admin%netbsd.org@localhost>, <netbsd-bugs%netbsd.org@localhost>
Cc: 
Subject: RE: kern/43958: Can't compile Atari kernel with ksyms pseudo-device
 enabled
Date: Sun, 7 Nov 2010 00:50:25 -0800

 David=2C
 =20
 Ahh...  if I explicitly include <sys/exec_elf.h> then it starts building.  =
 Then I realized I had disabled DDB in my kernel config.  Once I enabled DDB=
  again I was able to build just fine with ksyms.
 =20
 I'm not sure if it's completely nonsensical to build the kernel with ksyms =
 but without DDB.  If that's the case then this bug should be closed.  Other=
 wise maybe it makes sense to remove "defined(DDB) &&" from the conditional =
 regulating the inclusion of <sys/exec_elf.h>?
 =20
 David Ross
 dross%pobox.com@localhost
 
 ----------------------------------------
 > From: dholland-bugs%netbsd.org@localhost
 > To: kern-bug-people%netbsd.org@localhost=3B 
 > gnats-admin%netbsd.org@localhost=3B netbsd-bugs@n=
 etbsd.org=3B dross%pobox.com@localhost
 > Subject: Re: kern/43958: Can't compile Atari kernel with ksyms pseudo-dev=
 ice enabled
 > CC:
 > Date: Sun=2C 10 Oct 2010 02:15:04 +0000
 >
 > The following reply was made to PR kern/43958=3B it has been noted by GNA=
 TS.
 >
 > From: David Holland=20
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc:
 > Subject: Re: kern/43958: Can't compile Atari kernel with ksyms
 > pseudo-device enabled
 > Date: Sun=2C 10 Oct 2010 02:13:50 +0000
 >
 > On Sat=2C Oct 09=2C 2010 at 11:40:00PM +0000=2C dross%pobox.com@localhost 
 > wrote:
 > > /usr/src/sys/arch/atari/atari/machdep.c: In function 'consinit':
 > > /usr/src/sys/arch/atari/atari/machdep.c:209: error: 'Elf32_Ehdr' undecl=
 ared (first use in this function)
 > > /usr/src/sys/arch/atari/atari/machdep.c:209: error: (Each undeclared id=
 entifier is reported only once
 > > /usr/src/sys/arch/atari/atari/machdep.c:209: error: for each function i=
 t appears in.)
 >
 > Is there any reason not to move the inclusion of ksyms.h up along with
 > the opt_*.h near the top of the file?
 >
 > Then you can change line 110 to match line 200:
 >
 > -#if defined(DDB) && defined(__ELF__)
 > +#if (NKSYMS || defined(DDB) || defined(LKM)) && defined(__ELF__)
 > #include <sys/exec_elf.h>
 > #endif
 >
 > (Note: for HEAD=2C s/LKM/MODULAR/)
 >
 > --
 > David A. Holland
 > dholland%netbsd.org@localhost
 >                                        =