Re: kern/43958: Can't compile Atari kernel with ksyms pseudo-device enabled

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/43958; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/43958: Can't compile Atari kernel with ksyms
 pseudo-device enabled
Date: Sun, 10 Oct 2010 02:13:50 +0000

 On Sat, Oct 09, 2010 at 11:40:00PM +0000, dross%pobox.com@localhost wrote:
  > /usr/src/sys/arch/atari/atari/machdep.c: In function 'consinit':
  > /usr/src/sys/arch/atari/atari/machdep.c:209: error: 'Elf32_Ehdr' undeclared 
(first use in this function)
  > /usr/src/sys/arch/atari/atari/machdep.c:209: error: (Each undeclared 
identifier is reported only once
  > /usr/src/sys/arch/atari/atari/machdep.c:209: error: for each function it 
appears in.)
 
 Is there any reason not to move the inclusion of ksyms.h up along with
 the opt_*.h near the top of the file?
 
 Then you can change line 110 to match line 200:
 
    -#if defined(DDB) && defined(__ELF__)
    +#if (NKSYMS || defined(DDB) || defined(LKM)) && defined(__ELF__)
    #include <sys/exec_elf.h>
    #endif
 
 (Note: for HEAD, s/LKM/MODULAR/)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost