kern/43646: radeondrm needs firmload (+PATCH)

[kre%munnari.OZ.AU@localhost]

>Number:         43646
>Category:       kern
>Synopsis:       radeondrm needs firmload (+PATCH)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 20 18:45:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 5.99.36 (2010-07-20)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_RC3 NetBSD 5.1_RC3 (JADE-1.12-20100614) 
#2: Mon Jun 14 08:35:26 ICT 2010 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5.1/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        The DRM driver for ATI radeon needs the firmload system,
        but the kernel conf files don't cause it to be included.

>How-To-Repeat:
        Build a current kernel using a config where the only driver
        included that needs loadable firmware is the radeon drm, it
        will fail to link with the firmload functions missing, but
        references from radeon_drv.c

>Fix:
        The patch below corrects this for me.

Index: drm/conf/files.drm
===================================================================
RCS file: /cvsroot/NetBSD/src/sys/external/bsd/drm/conf/files.drm,v
retrieving revision 1.4
diff -u -r1.4 files.drm
--- drm/conf/files.drm  6 Jul 2010 16:33:31 -0000       1.4
+++ drm/conf/files.drm  20 Jul 2010 18:20:11 -0000
@@ -87,7 +87,7 @@
 file   external/bsd/drm/dist/shared-core/r128_irq.c            r128drm
 file   external/bsd/drm/dist/shared-core/r128_state.c          r128drm
 
-device radeondrm: drmbase, drmpci
+device radeondrm: drmbase, drmpci, firmload
 attach radeondrm at drm
 file   external/bsd/drm/dist/bsd-core/radeon_drv.c             radeondrm
 file   external/bsd/drm/dist/shared-core/r300_cmdbuf.c         radeondrm