Re: kern/43541: Unaligned access in pf_normalize_tcpopt()

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/43541; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/43541: Unaligned access in pf_normalize_tcpopt()
Date: Tue, 29 Jun 2010 20:12:11 +0000

 On Mon, Jun 28, 2010 at 04:35:00PM +0000, gandersen%cradlepoint.com@localhost 
wrote:
  > +                           optp[2] = (u_char)(r->max_mss >> 8) & 0xff;
  > +                           optp[3] = (u_char)(r->max_mss) & 0xff;
 
 Do those casts serve any purpose?
 
 otherwise, seems like a desirable patch...
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost