NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

port-hpcmips/43474: Wrong structure in txcon_txintr



>Number:         43474
>Category:       port-hpcmips
>Synopsis:       Wrong structure in txcon_txintr
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-hpcmips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 14 21:10:01 +0000 2010
>Originator:     Risto Sainio
>Release:        NetBSD 5.0.2_PATCH
>Organization:
>Environment:
NetBSD rsa02.rsa.org 5.0.2_PATCH NetBSD 5.0.2_PATCH (TX3922_rsa) #22: Sat Jun 
12 01:50:35 CEST 2010  
root@vrsa89:/usr/objdir_current/sys/arch/hpcmips/compile/TX3922_rsa hpcmips

>Description:
Looks that in .../hpcmips/tx/txcom.c in function txcom_txintr the callout_reset 
should use sc->sc_txsoft_ch instead of sc->sc_rxsoft_ch as argument
>How-To-Repeat:

>Fix:
int
txcom_txintr(void *arg)
{
        struct txcom_softc *sc = arg;
        struct txcom_chip *chip = sc->sc_chip;
        tx_chipset_tag_t tc = chip->sc_tc;

        if (sc->sc_tbc > 0) {
                tx_conf_write(tc, TX39_UARTTXHOLD_REG(chip->sc_slot),
                    (*sc->sc_tba &
                        TX39_UARTTXHOLD_TXDATA_MASK));
                sc->sc_tbc--;
                sc->sc_tba++;
        } else {
                callout_reset(&sc->sc_txsoft_ch, 1, txcom_txsoft, sc);
        }

        return 0;
}




Home | Main Index | Thread Index | Old Index