NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: misc/43401: typo in sdpd rc.d script



Jukka Salmi --> netbsd-bugs (2010-06-01 16:15:00 +0000):
> >Description:
> Typo in etc/rc.d/sdpd: $_rc_subr_loaded is missing its leading underscore.
> This causes rc.subr to be sourced unconditionally.
> >How-To-Repeat:
> n/a
> >Fix:
> The following patch is also available from
> http://salmi.ch/~jukka/patches/NetBSD/src/HEAD/etc/rc.d/sdpd.patch
> 
> Index: etc/rc.d/sdpd
> ===================================================================
> RCS file: /cvsroot/src/etc/rc.d/sdpd,v
> retrieving revision 1.2
> diff -u -p -r1.2 sdpd
> --- etc/rc.d/sdpd     18 Mar 2007 15:53:54 -0000      1.2
> +++ etc/rc.d/sdpd     1 Jun 2010 16:02:26 -0000
> @@ -7,7 +7,7 @@
>  # REQUIRE: bluetooth
>  # BEFORE: LOGIN
>  
> -$rc_subr_loaded . /etc/rc.subr
> +$_rc_subr_loaded . /etc/rc.subr
>  
>  name="sdpd"
>  rcvar=$name

I just noticed the same problem exists for the bthcid rc.d script.
Patch attached.


Cheers, Jukka

-- 
This email fills a much-needed gap in the archives.
Index: etc/rc.d/bthcid
===================================================================
RCS file: /cvsroot/src/etc/rc.d/bthcid,v
retrieving revision 1.1
diff -u -p -r1.1 bthcid
--- etc/rc.d/bthcid     19 Jun 2006 15:44:36 -0000      1.1
+++ etc/rc.d/bthcid     1 Jun 2010 16:15:49 -0000
@@ -7,7 +7,7 @@
 # REQUIRE: bluetooth
 # BEFORE: LOGIN
 
-$rc_subr_loaded . /etc/rc.subr
+$_rc_subr_loaded . /etc/rc.subr
 
 name="bthcid"
 rcvar=$name


Home | Main Index | Thread Index | Old Index