kern/43341: firewire code is broken from the kmem_alloc changes.

[christos%netbsd.org@localhost]

>Number:         43341
>Category:       kern
>Synopsis:       firewire code is broken from the kmem_alloc changes.
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 23 05:20:01 +0000 2010
>Originator:     Christos Zoulas
>Release:        NetBSD 5.99.28
>Organization:
        Broken Kernels
>Environment:
System: NetBSD bulky.astron.com 5.99.28 NetBSD 5.99.28 (BULKY) #36: Sat May 1 
21:52:04 EDT 2010 
christos%bulky.astron.com@localhost:/usr/src/sys/arch/amd64/compile/BULKY amd64
Architecture: x86_64
Machine: amd64
>Description:
        Whoever changed the firewire code to use kmem_alloc() did not
        test the kernel with DIAGNOSTIC because there are kmem_alloc()
        calls from an interrupt context all over the place.
        I fixed the first two I found, but I am stopping here.
>How-To-Repeat:
        Compile a DIAGNOSTIC kernel and boot.

fwohci0: BUS reset
fwohci0: node_id=0xc800ffc0, gen=1, CYCLEMASTER mode
ieee1394if0: 1 nodes, maxhop <= 0 cable IRM irm(0) (me)
ieee1394if0: bus manager 0
panic: kernel diagnostic assertion "!cpu_intr_p()" failed: file "../../../../ker
n/subr_kmem.c", line 195
fatal breakpoint trap in supervisor mode
trap type 1 code 0 rip ffffffff8022db1d cs 8 rflags 246 cr2  0 cpl 6 rsp fffffff
f80faf628
breakpoint() at netbsd:breakpoint+0x5
panic() at netbsd:panic+0x2ba
kern_assert() at netbsd:kern_assert+0x2d
kmem_alloc() at netbsd:kmem_alloc+0x18a
kmem_zalloc() at netbsd:kmem_zalloc+0xf
fw_xfer_alloc() at netbsd:fw_xfer_alloc+0x19
fw_bmr() at netbsd:fw_bmr+0x174
fw_sidrcv() at netbsd:fw_sidrcv+0x5e7
fwohci_intr() at netbsd:fwohci_intr+0xc52
intr_biglock_wrapper() at netbsd:intr_biglock_wrapper+0x1d
Xintr_ioapic_level5() at netbsd:Xintr_ioapic_level5+0xf4
--- interrupt ---
Xspllower() at netbsd:Xspllower+0xe
main() at netbsd:main+0x216

>Fix:

Perhaps allocate a pool of transfers, or back the whole thing out.