Re: kern/43318: Recent -current asserts with USB activity

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR kern/43318; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost,
        scotte%warped.com@localhost
Subject: Re: kern/43318: Recent -current asserts with USB activity
Date: Wed, 19 May 2010 19:07:17 +0200

 --y0ulUmNC+osPPQO6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Wed, May 19, 2010 at 06:32:26PM +0200, Manuel Bouyer wrote:
 > Then can you try the attached patch, and report if the
 > printf("syn dropped\n") does show up in the kernel log ?
 > Also, it should fix the assert problem.
 
 With the patch, this time
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --
 
 --y0ulUmNC+osPPQO6
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=diff
 
 Index: tcp_input.c
 ===================================================================
 RCS file: /cvsroot/src/sys/netinet/tcp_input.c,v
 retrieving revision 1.304
 diff -u -p -u -r1.304 tcp_input.c
 --- tcp_input.c        21 Apr 2010 20:40:16 -0000      1.304
 +++ tcp_input.c        19 May 2010 16:31:16 -0000
 @@ -4207,6 +4207,12 @@ syn_cache_add(struct sockaddr *src, stru
                syn_cache_insert(sc, tp);
        } else {
                s = splsoftnet();
 +              printf("syn dropped\n");
 +              /*
 +               * syn_cache_put() will try to schedule the timer, so
 +               * we need to initialize it
 +               */
 +              SYN_CACHE_TIMER_ARM(sc);
                syn_cache_put(sc);
                splx(s);
                TCP_STATINC(TCP_STAT_SC_DROPPED);
 
 --y0ulUmNC+osPPQO6--