Re: port-i386/43189: compiling i386 ALL with "options PERFCTRS" fails

[Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>]

The following reply was made to PR port-i386/43189; it has been noted by GNATS.

From: Jean-Yves Migeon <jeanyves.migeon%free.fr@localhost>
To: NetBSD GNATS <gnats-bugs%NetBSD.org@localhost>
Cc: "Greg A. Woods" <woods%planix.com@localhost>, jym%netbsd.org@localhost
Subject: Re: port-i386/43189: compiling i386 ALL with "options PERFCTRS" fails
Date: Thu, 22 Apr 2010 20:40:53 +0200

 On 04/22/10 19:35, Greg A. Woods wrote:
  > One more change is necessary to complete the compile of ALL:
 
 Index: sys/arch/i386/i386/pmc.c
 ===================================================================
 RCS file: /cvs/master/m-NetBSD/main/src/sys/arch/i386/i386/pmc.c,v
 retrieving revision 1.17
 diff -u -r1.17 pmc.c
 --- sys/arch/i386/i386/pmc.c   11 May 2008 14:44:54 -0000      1.17
 +++ sys/arch/i386/i386/pmc.c   21 Apr 2010 21:30:25 -0000
 @@ -122,7 +122,7 @@
                break;
        }
 
 -      if (pmc_type != PMC_TYPE_NONE && (cpu_feature & CPUID_TSC) != 0)
 +      if (pmc_type != PMC_TYPE_NONE && cpu_hascounter())
                pmc_flags |= PMC_INFO_HASTSC;
 
   #ifdef MULTIPROCESSOR
 
 
 
 Ah yes, I forgot that check for TSC; your patch is correct.
 
 -- 
 Jean-Yves Migeon
 jeanyves.migeon%free.fr@localhost