Re: kern/43185 (bpf_validate() uses BPF_RVAL() when it should use BPF_SRC())

[Guy Harris <guy%alum.mit.edu@localhost>]

The following reply was made to PR kern/43185; it has been noted by GNATS.

From: Guy Harris <guy%alum.mit.edu@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
gnats-admin%netbsd.org@localhost,
        drochner%netbsd.org@localhost
Subject: Re: kern/43185 (bpf_validate() uses BPF_RVAL() when it should use 
BPF_SRC())
Date: Wed, 21 Apr 2010 09:56:28 -0700

 On Apr 21, 2010, at 9:40 AM, drochner%netbsd.org@localhost wrote:
 
 > Synopsis: bpf_validate() uses BPF_RVAL() when it should use BPF_SRC()
 >=20
 > State-Changed-From-To: open->closed
 > State-Changed-By: drochner%NetBSD.org@localhost
 > State-Changed-When: Wed, 21 Apr 2010 16:40:32 +0000
 > State-Changed-Why:
 > fix applied, thanks. Good catch!
 
 I can't take credit for it - the reason I just filed several bugs =
 against various BPF implementations is that I'd filed bugs against them =
 earlier, with a patch to add OpenBSD's additional checking, and had =
 assumed the OpenBSD code was correct, so they all followed OpenBSD and =
 picked up its bug (well, FreeBSD did it differently, and didn't pick up =
 the bug).  The fixer of one of those bugs *did* notice, and I noticed =
 their change.
 
 > Did you report this to the
 > libpcap/tcpdump maintainers?
 
 Given that I'm one of the libpcap/tcpdump maintainers, I didn't have to. =
 :-)  I've checked the fix into its bpf_validate(), in both the main and =
 1.1 Git branches.=