kern/43176: pfind considered lethal

[pooka%iki.fi@localhost]

>Number:         43176
>Category:       kern
>Synopsis:       pfind considered lethal
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 19 11:00:01 +0000 2010
>Originator:     Antti Kantee
>Release:        
>Organization:
>Environment:
>Description:
pfind() does p_find(UNLOCKED) giving a dangerous and
racy result for any non-boolean query done without proc_lock held.
At least one bug exists because of this in kern_resource.c
sysctl_proc_findproc().
>How-To-Repeat:

>Fix:
get rid of pfind macro.  ad suggests also to critically examine the
p_find() function interface.