Re: kern/42550: possible year2038 problem in MI todr(9)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR kern/42550; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost,
        tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/42550: possible year2038 problem in MI todr(9)
Date: Sat, 3 Apr 2010 01:56:02 +0900

 > I saw similar hang on mac68k with dead battery
 > and the problem was resolved after TOD value was corrected.
 > 
 > >Fix:
 > Unknown. Check all possible 32bit overflow?
 
 It looks the following patch (time_t vs long bug) fixes hang
 on boot where TODR year is >2038:
 
 Index: miscfs/syncfs/sync_subr.c
 ===================================================================
 RCS file: /cvsroot/src/sys/miscfs/syncfs/sync_subr.c,v
 retrieving revision 1.41
 diff -u -r1.41 sync_subr.c
 --- miscfs/syncfs/sync_subr.c  16 Sep 2009 15:23:04 -0000      1.41
 +++ miscfs/syncfs/sync_subr.c  2 Apr 2010 16:51:50 -0000
 @@ -224,7 +224,7 @@
  {
        struct synclist *slp;
        struct vnode *vp;
 -      long starttime;
 +      time_t starttime;
        bool synced;
  
        updateproc = curlwp;
 
 ---
 Izumi Tsutsui