bin/42943: pppd generates invalid netmask

[sogabe%iij.ad.jp@localhost]

>Number:         42943
>Category:       bin
>Synopsis:       pppd generates invalid netmask
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 10 06:35:00 +0000 2010
>Originator:     Takashi Sogabe
>Release:        3.0
>Organization:
Internet Initiative Japan., Inc.
>Environment:
(n/a)
>Description:
In sys-bsd.c(usr.sbin/pppd/pppd), GetMask() generates invalid netmask.

>How-To-Repeat:

>Fix:
Remove '&' in GetMask().

sys-bsd.c:GetMask()
(original code)
        /*
         * Get its netmask and OR it into our mask.
         */
        mask |= ((struct sockaddr_in *)&ifa->ifa_netmask)->sin_addr.s_addr;

(fixed code)
        /*
         * Get its netmask and OR it into our mask.
         */
        mask |= ((struct sockaddr_in *)ifa->ifa_netmask)->sin_addr.s_addr;