Re: kern/42225 (can't read data from SuperTop IDE Bridge (umass))

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/42225; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Matthias Kretschmer <kretschm%cs.uni-bonn.de@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/42225 (can't read data from SuperTop IDE Bridge (umass))
Date: Thu, 11 Feb 2010 11:09:25 +0100

 On Thu, Feb 11, 2010 at 10:39:46AM +0100, Matthias Kretschmer wrote:
 > - I changed the code for setting "residue" to
 > 
 >   residue = UGETDW(dCSWDataResidue);
 >   if (residue < sc->transfer_datalen - sc->transfer_actlen)
 >       residue = sc->transfer_datalen - sc->transfer_actlen;
 > 
 >   which works with my usb device.  I just do not have another umass
 >   at hand to test with.
 
 Cool - this is what I expected.
 
 IMHO this can go in unconditionally. There is no way for the device to 
 "reconnect" and send more data later, so limiting to the actual transfer
 length can not cause any harm.
 
 I will test with a few other devices and commit ASAP.
 
 Martin