Re: bin/42654: Coverity Scan Issues on ls.c

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR bin/42654; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: netbsd-bugs%NetBSD.org@localhost
Subject: Re: bin/42654: Coverity Scan Issues on ls.c
Date: Thu, 28 Jan 2010 20:19:02 +0200

 On Wed, 20 Jan 2010, joel.sherrill%gmail.com@localhost wrote:
 > The RTEMS Project is using some code pulled in from NetBSD.  We are
 > also part of the Coverity Scan project for free software projects.  We
 > have two Coverity "results" on ls.c CVS id 1.58 which are reported as
 > dead code. [...]
 
 > 630                                           if (f_flags && flags) {
 
 This line does not appear in revision 1.58 of NetBSD's src/bin/ls/ls.c.
 
 > 631                                                  np->flags = 
 > &np->data[ulen + glen + 2];
 > 632                                                  (void)strcpy(np->flags, 
 > flags);
 
 Lines with content like this do appear, as lines 570 and 571 of revision
 1.58 of NetBSD's src/bin/ls/ls.c.  However, the fact that the line
 numbers are different indicates that the file you checked is not the
 file from NetBSD.  It's not at all clear, from what you have told us so
 far, that your Coverity report applies to NetBSD's version of ls.c.
 
 --apb (Alan Barrett)