Re: port-sparc/23399 (sys/dev/sbus/zx* is unnecessarily sketchy)

[der Mouse <mouse%Rodents-Montreal.ORG@localhost>]

The following reply was made to PR port-sparc/23399; it has been noted by GNATS.

From: der Mouse <mouse%Rodents-Montreal.ORG@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-sparc/23399 (sys/dev/sbus/zx* is unnecessarily sketchy)
Date: Mon, 25 Jan 2010 09:14:43 -0500 (EST)

 > this driver has been majorly overhauled by macallan in the years
 > since this PR was logged.  i suspect it's now closed, but can you
 > have a look?
 
 I think the best operational approximation for purposes of this PR is
 "no improvement".
 
 All the specific UNK #defines cited in the PR are still present - as
 UNKs - in zxreg.h,v 1.7, dated 2009-04-23.  (I _think_ that's the
 latest - I tried to have cvs to update my local copy, and think it did,
 but I'm not certain.  I do note it's substantially newer than 4.0.1's,
 which is the newest source tree I have unpacked at ready hand.)
 
 A quick look at the code (zx.c,v 1.35) makes me think whatever has been
 done didn't actually address any of these, probably just copying the
 relevant bits from the former driver - I suspect the overhaul was aimed
 at other things, not at addressing any part of this PR.
 
 In particular, zx_cross_wait is still called that, even though it is
 actually wait-for-completion only for WID and LUT transfers, and the
 cursor code is still full of magic numbers like 0x30 and 0x80 and 0x20
 (and the 0x20<<j is still there and I still think it's wrong, though
 I'm not as sure as I was when I wrote the PR that it should be 0x20*j).
 
 I didn't check out the rest of the things the PR mentions; I don't
 really have the leisure right now to get my head back around the zx -
 unfortunately, my note to the PR of 2004-03-28 still applies. :(
 
 /~\ The ASCII                            Mouse
 \ / Ribbon Campaign
  X  Against HTML               mouse%rodents-montreal.org@localhost
 / \ Email!          7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B