NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

port-next68k/42529: Delete parenthesies in sys/arch/next68k/dev/nextdma.c .



>Number:         42529
>Category:       port-next68k
>Synopsis:       Delete  parenthesies in sys/arch/next68k/dev/nextdma.c .
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-next68k-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 27 08:45:03 +0000 2009
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Too many parentheses found with cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.45 nextdma.c
--- sys/arch/next68k/dev/nextdma.c      5 Nov 2009 18:11:09 -0000       1.45
+++ sys/arch/next68k/dev/nextdma.c      1 Dec 2009 11:46:13 -0000
@@ -209,7 +209,7 @@
                char sbuf[256];
 
                snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-                   (NEXT_I_BIT(nsc->sc_chan->nd_intr));
+                   NEXT_I_BIT(nsc->sc_chan->nd_intr));
                printf("DMA init ipl (%ld) intr(0x%s)\n",
                        NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
        }
@@ -493,7 +493,7 @@
                char sbuf[256];
 
                snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-                   (NEXT_I_BIT(nsc->sc_chan->nd_intr));
+                   NEXT_I_BIT(nsc->sc_chan->nd_intr));
                printf("DMA interrupt ipl (%ld) intr(0x%s)\n",
                       NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
        }
@@ -906,7 +906,7 @@
        printf("NDMAP: dd->dd_stop         = 0x%08lx\n", dd_stop);
 
        snprintb(sbuf, sizeof(sbuf), NEXT_INTR_BITS,
-           (NEXT_I_BIT(nsc->sc_chan->nd_intr)));
+           NEXT_I_BIT(nsc->sc_chan->nd_intr));
        printf("NDMAP: interrupt ipl (%ld) intr(0x%s)\n",
                        NEXT_I_IPL(nsc->sc_chan->nd_intr), sbuf);
 }



Home | Main Index | Thread Index | Old Index