bin/42460: build of tools fails in binutils on netbsd-4/i386

["Greg A. Woods" <woods%planix.com@localhost>]

>Number:         42460
>Category:       bin
>Synopsis:       build of tools fails in binutils on netbsd-4/i386
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 15 23:50:00 +0000 2009
>Originator:     Greg A. Woods
>Release:        current 2009/12/15-23hZ
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
Build-System: NetBSD 4.0_STABLE
Build-Architecture: i386
Build-Machine: i386
Target-System: NetBSD-current
Target-Architecture: evbmips-eb
Target-Machine: mips-eb
>Description:

        Attempting to build tools for netbsd/current evbmips-eb fails on
        a NetBSD-4 host system.

>How-To-Repeat:

        build.sh -m evbmips-eb [[...]] tools

--- cache.lo ---
libtool: compile:  cc -DHAVE_CONFIG_H -I. 
-I/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd
 -I. -I. 
-I/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd
 
-I/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd/../include
 -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -pipe -O2 
-march=pentiumpro -W -Wall -Wstrict-prototypes -Wmissing-prototypes 
-Wpointer-arith -Wno-uninitialized -g -c 
/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd/cache.c
 -o cache.o
cc1: warnings being treated as errors
/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd/cache.c:
 In function 'cache_bread':
/rest/work/woods/m-NetBSD-current/tools/binutils/../../external/gpl3/binutils/dist/bfd/cache.c:320:
 warning: pointer of type 'void *' used in arithmetic
        

>Fix:

        this should fix things well enough


Index: external/gpl3/binutils/dist/bfd/cache.c
===================================================================
RCS file: 
/cvs/master/m-NetBSD/main/src/external/gpl3/binutils/dist/bfd/cache.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 cache.c
--- external/gpl3/binutils/dist/bfd/cache.c     18 Aug 2009 09:23:32 -0000      
1.1.1.1
+++ external/gpl3/binutils/dist/bfd/cache.c     15 Dec 2009 23:32:34 -0000
@@ -317,7 +317,7 @@
       if (chunk_size > max_chunk_size)
         chunk_size = max_chunk_size;
 
-      chunk_nread = cache_bread_1 (abfd, buf + nread, chunk_size);
+      chunk_nread = cache_bread_1 (abfd, (char *) buf + nread, chunk_size);
 
       /* Update the nread count.