bin/42161: systat(1) "The alternate system clock has died" annoying message

[stix%stix.id.au@localhost]

>Number:         42161
>Category:       bin
>Synopsis:       systat(1) "The alternate system clock has died" annoying 
>message
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 07 10:55:02 +0000 2009
>Originator:     Paul Ripke
>Release:        NetBSD 5.0_STABLE
>Organization:
>Environment:
System: NetBSD zion.stix.org.au 5.0_STABLE NetBSD 5.0_STABLE (ZION) #3: Fri Sep 
11 18:21:34 EST 2009 
stix%zion.stix.org.au@localhost:/export/netbsd/netbsd-5/obj.i386/export/netbsd/netbsd-5/src/sys/arch/i386/compile/ZION
 i386

Architecture: i386
Machine: i386
>Description:

I usually leave a "systat vm" running in GNU screen, and regularly
attach from varios xterms of differing sizes. Frequently, the SIGWINCH
results in systat saying "The alternate system clock has died" and
reverts to the 'pigs' display.

>How-To-Repeat:

See above.

>Fix:

The following patch fixes the issue for me - occasionally a rather blank
or slightly garbled screen is displayed, but this is cleaned up on the
next refresh. This is a rather obvious bug :)

Index: usr.bin/systat/syscall.c
===================================================================
RCS file: /usr/netbsd/cvsroot/src/usr.bin/systat/syscall.c,v
retrieving revision 1.5
diff -u -d -r1.5 syscall.c
--- usr.bin/systat/syscall.c    29 Apr 2008 06:53:04 -0000      1.5
+++ usr.bin/systat/syscall.c    7 Oct 2009 10:36:15 -0000
@@ -201,9 +201,8 @@
                etime = cur.cp_etime;
                /* < 5 ticks - ignore this trash */
                if ((etime * hertz) < 1.0) {
-                       if (failcnt++ > MAXFAIL)
+                       if (failcnt++ <= MAXFAIL)
                                return;
-                       failcnt = 0;
                        clear();
                        mvprintw(2, 10, "The alternate system clock has died!");
                        mvprintw(3, 10, "Reverting to ``pigs'' display.");
Index: usr.bin/systat/vmstat.c
===================================================================
RCS file: /usr/netbsd/cvsroot/src/usr.bin/systat/vmstat.c,v
retrieving revision 1.71
diff -u -d -r1.71 vmstat.c
--- usr.bin/systat/vmstat.c     13 Jul 2008 20:07:48 -0000      1.71
+++ usr.bin/systat/vmstat.c     7 Oct 2009 10:36:27 -0000
@@ -498,7 +498,7 @@
                etime = cur.cp_etime;
                /* < 5 ticks - ignore this trash */
                if ((etime * hertz) < 1.0) {
-                       if (failcnt++ > MAXFAIL)
+                       if (failcnt++ <= MAXFAIL)
                                return;
                        clear();
                        mvprintw(2, 10, "The alternate system clock has died!");