bin/42159: /usr/tests/** files use HOST_SH instead of /bin/sh

[apb%cequrux.com@localhost]

>Number:         42159
>Category:       bin
>Synopsis:       /usr/tests/** files use HOST_SH instead of /bin/sh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 06 19:10:00 +0000 2009
>Originator:     Alan Barrett
>Release:        NetBSD 5.99.18
>Organization:
Not much
>Environment:
System: NetBSD 5.99.18
Architecture: i386
Machine: i386
>Description:
        When a build is done using build.sh, many shell scripts
        under ${DESTDIR}/usr/tests have the value of ${HOST_SH}
        instead of /bin/sh in the #! line.

        These scripts are build products intended to run
        on the target system, not on the build system, so it's
        wrong for them to use ${HOST_SH}.

>How-To-Repeat:
        $ HOST_SH=/usr/pkg/bin/bash ./build.sh build

        $ head -1 ${DESTDIR}/usr/tests/atf/test_programs/t_config
        #! /usr/pkg/bin/bash

>Fix:
        Fix the build process to pass ATF_SHELL=/bin/sh in appropriate
        places.  Parts of ATF that run on the host should use
        ${HOST_SH}, and parts of ATF that run on the target should use
        /bin/sh.