port-macppc/41916: dbcool at ki2c should support adm1030

[Taylor R Campbell <campbell%mumble.net@localhost>]

>Number:         41916
>Category:       port-macppc
>Synopsis:       dbcool at ki2c should support adm1030
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-macppc-maintainer
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 22 01:35:00 +0000 2009
>Originator:     Taylor R Campbell <campbell%mumble.net@localhost>
>Release:        NetBSD 5.0_STABLE
>Organization:
>Environment:
System: NetBSD joule.t.continuation.org 5.0_STABLE NetBSD 5.0_STABLE (RIAGATE) 
#0: Sun Jun 14 17:49:06 EDT 2009 
riastradh%Oberon.local@localhost:/Users/riastradh/os/netbsd/5/obj/sys/arch/i386/compile/RIAGATE
 i386
Architecture: i386
Machine: i386
>Description:

        I have tested an aluminium 12" PowerBook that has a fan device
        under ki2c reporting a `compatible' property of `adm1030',
        which NetBSD does not currently recognize.  However, the
        dbcool(4) driver is able to talk with it, once the dbcool_ki2c
        device passes it through.

        Caveat: While envstat's temperature readout looked plausible,
        its fan readout lied to me -- it claimed that the fan was
        spinning at six thousand RPM when the fan was silent and
        obviously not propelling air out the vent.  However, this
        PowerBook has had beer spilt on it, so I'm inclined to suspect
        that the problem is just with the fan hardware.  The keyboard
        and possibly the FireWire controller were also unhappy after
        their drunken spell.

        In another very similar PowerBook (one model later, with an
        adt7460 rather than an adm1030), cleaning out the fan with a
        cotton swab and some alcohol caused it to spin at ten thousand
        RPM every time it booted from then on, and to stay spinning at
        that rate until the machine is shut down; it wouldn't surprise
        me if this part of the PowerBook were a little fragile.

>How-To-Repeat:

        Obtain such a PowerBook.  Invoke envstat(8).  Be disappointed
        at the lack of temperature sensor output.

>Fix:

        Apply the following patch to
        sys/arch/macppc/dev/dbcool_ki2c.c:

--- dbcool_ki2c.c       25 May 2009 11:36:52 -0400      1.3.6.1
+++ dbcool_ki2c.c       21 Aug 2009 20:51:18 -0400      

@@ -67,7 +67,8 @@
 
        memset(compat, 0, sizeof(compat));
        OF_getprop(ka->ka_node, "compatible", compat, sizeof(compat));
-       if (strcmp(compat, "adt7467") != 0 && strcmp(compat, "adt7460") != 0)
+       if (strcmp(compat, "adt7467") != 0 && strcmp(compat, "adt7460") != 0 &&
+           strcmp(compat, "adm1030") != 0)
                return 0;
        
        return 1;