Re: kern/41840: Missing parenthesis in puffs_vnops.c

[henning petersen <henning.petersen%t-online.de@localhost>]

The following reply was made to PR kern/41840; it has been noted by GNATS.

From: henning petersen <henning.petersen%t-online.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/41840: Missing parenthesis in puffs_vnops.c
Date: Fri, 07 Aug 2009 15:17:29 +0200

 henning.petersen%t-online.de@localhost schrieb:
 >> Number:         41840
 >> Category:       kern
 >> Synopsis:       Missing parenthesis in puffs_vnops.c
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       medium
 >> Responsible:    kern-bug-people
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Fri Aug 07 11:50:00 +0000 2009
 >> Originator:     Henning Petersen
 >> Release:        current-NetBSD
 >> Organization:
 >> Environment:
 >> Description:
 >>     
 > Missing parenthesis found with programm cppcheck.
 >   
 >> How-To-Repeat:
 >>     
 >
 >   
 >> Fix:
 >>     
 > RCS file: /cvsroot/src/sys/fs/puffs/puffs_vnops.c,v
 > retrieving revision 1.131
 > diff -r1.131 puffs_vnops.c
 > 2425c2425
 > <            pcinfo = kmem_zalloc(sizeof_puffs_cacheinfo) + runsize,
 > ---
 >   
 >>             pcinfo = kmem_zalloc((sizeof_puffs_cacheinfo) + runsize,
 >>     
 >
 >
 > __________ Information from ESET NOD32 Antivirus, version of virus signature 
 > database 4314 (20090807) __________
 >
 > The message was checked by ESET NOD32 Antivirus.
 >
 > http://www.eset.com
 >
 >
 >
 >
 >   
 --- sys/fs/puffs/puffs_vnops.c    26 Nov 2008 20:17:33 -0000    1.131
 +++ sys/fs/puffs/puffs_vnops.c    7 Aug 2009 12:17:38 -0000
 @@ -2422,7 +2422,7 @@
  #ifdef notnowjohn
          /* allocate worst-case memory */
          runsizes = ((npages / 2) + 1) * sizeof(struct puffs_cacherun);
 -        pcinfo = kmem_zalloc(sizeof_puffs_cacheinfo) + runsize,
 +        pcinfo = kmem_zalloc((sizeof_puffs_cacheinfo) + runsize,
              locked ? KM_NOSLEEP : KM_SLEEP);
  
          /*
 
 
 
 __________ Information from ESET NOD32 Antivirus, version of virus signature 
database 4314 (20090807) __________
 
 The message was checked by ESET NOD32 Antivirus.
 
 http://www.eset.com