Re: bin/41838: Missing parenthesis in wwterminfo.c

[henning petersen <henning.petersen%t-online.de@localhost>]

The following reply was made to PR bin/41838; it has been noted by GNATS.

From: henning petersen <henning.petersen%t-online.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/41838: Missing parenthesis in wwterminfo.c
Date: Fri, 07 Aug 2009 14:38:07 +0200

 henning.petersen%t-online.de@localhost schrieb:
 >> Number:         41838
 >> Category:       bin
 >> Synopsis:       Missing parenthesis in wwterminfo.c
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       medium
 >> Responsible:    bin-bug-people
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Fri Aug 07 11:40:00 +0000 2009
 >> Originator:     Henning Petersen
 >> Release:        Netbsd-current
 >> Organization:
 >> Environment:
 >> Description:
 >>     
 > Missing parenthesis found with programm cppcheck.
 >   
 >> How-To-Repeat:
 >>     
 >
 >   
 >> Fix:
 >>     
 > RCS file: /cvsroot/src/usr.bin/window/wwterminfo.c,v
 > retrieving revision 1.5
 > diff -r1.5 wwterminfo.c
 > 76c76
 > <    if (mkdtemp(wwterminfopath) == NULL) ||
 > ---
 >   
 >>     if ((mkdtemp(wwterminfopath) == NULL) ||
 >>     
 >
 >
 > __________ Information from ESET NOD32 Antivirus, version of virus signature 
 > database 4314 (20090807) __________
 >
 > The message was checked by ESET NOD32 Antivirus.
 >
 > http://www.eset.com
 >
 >
 >
 >
 >   
 diff -u -r1.5 wwterminfo.c
 --- usr.bin/window/wwterminfo.c    7 Aug 2003 11:17:45 -0000    1.5
 +++ usr.bin/window/wwterminfo.c    7 Aug 2009 12:16:45 -0000
 @@ -73,7 +73,7 @@
  
          /* make the directory */
      (void) sprintf(wwterminfopath, "%swwinXXXXXX", _PATH_TMP);
 -    if (mkdtemp(wwterminfopath) == NULL) ||
 +    if ((mkdtemp(wwterminfopath) == NULL) ||
          chmod(wwterminfopath, 0755) < 0) {
          wwerrno = WWE_SYS;
          return -1;
 
 
 
 __________ Information from ESET NOD32 Antivirus, version of virus signature 
database 4314 (20090807) __________
 
 The message was checked by ESET NOD32 Antivirus.
 
 http://www.eset.com