Re: kern/41841: Missing parenthesis in lfs_segment.c

[henning petersen <henning.petersen%t-online.de@localhost>]

The following reply was made to PR kern/41841; it has been noted by GNATS.

From: henning petersen <henning.petersen%t-online.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/41841: Missing parenthesis in lfs_segment.c
Date: Fri, 07 Aug 2009 14:41:54 +0200

 henning.petersen%t-online.de@localhost schrieb:
 >> Number:         41841
 >> Category:       kern
 >> Synopsis:       Missing parenthesis in lfs_segment.c
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       medium
 >> Responsible:    kern-bug-people
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Fri Aug 07 11:50:00 +0000 2009
 >> Originator:     Henning Petersen
 >> Release:        current-NetBSD
 >> Organization:
 >> Environment:
 >> Description:
 >>     
 > Missing parenthesis found with programm cppcheck.
 >   
 >> How-To-Repeat:
 >>     
 >
 >   
 >> Fix:
 >>     
 > RCS file: /cvsroot/src/sys/ufs/lfs/lfs_segment.c,v
 > retrieving revision 1.213
 > diff -r1.213 lfs_segment.c
 > 2153c2153
 > <                    if ((*bpp)->b_cflags & BC_INVAL) != 0 &&
 > ---
 >   
 >>                     if (((*bpp)->b_cflags & BC_INVAL) != 0 &&
 >>     
 >
 >
 > __________ Information from ESET NOD32 Antivirus, version of virus signature 
 > database 4314 (20090807) __________
 >
 > The message was checked by ESET NOD32 Antivirus.
 >
 > http://www.eset.com
 >
 >
 >
 >
 >   
 diff -u -r1.213 lfs_segment.c
 --- sys/ufs/lfs/lfs_segment.c    2 Jun 2008 16:25:34 -0000    1.213
 +++ sys/ufs/lfs/lfs_segment.c    7 Aug 2009 12:17:44 -0000
 @@ -2150,7 +2150,7 @@
          for (byteoffset = 0; byteoffset < (*bpp)->b_bcount;
               byteoffset += fs->lfs_bsize) {
  #ifdef LFS_USE_B_INVAL
 -            if ((*bpp)->b_cflags & BC_INVAL) != 0 &&
 +            if (((*bpp)->b_cflags & BC_INVAL) != 0 &&
                  (*bpp)->b_iodone != NULL) {
                  if (copyin((void *)(*bpp)->b_saveaddr +
                         byteoffset, dp, el_size)) {
 
 
 
 __________ Information from ESET NOD32 Antivirus, version of virus signature 
database 4314 (20090807) __________
 
 The message was checked by ESET NOD32 Antivirus.
 
 http://www.eset.com