re: misc/38425 (savecore confused if getbootfile(3) fails)

[Tom Spindler <dogcow%babymeat.com@localhost>]

The following reply was made to PR misc/38425; it has been noted by GNATS.

From: Tom Spindler <dogcow%babymeat.com@localhost>
To: gnats-bugs%NetBSD.org@localhost, Thor Lancelot Simon 
<tls%rek.tjls.com@localhost>
Cc: misc-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost, Simon Burge 
<simonb%NetBSD.org@localhost>
Subject: re: misc/38425 (savecore confused if getbootfile(3) fails)
Date: Sun, 14 Jun 2009 06:50:17 -0700

 I don't know about any of you, but savecore completely fails to work
 for me after 1.78 savecore.c; in particular, failing to set the
 booted kernel causes check_space to die a painful death:
 
        if (stat(kernel, &st) < 0) {
                syslog(LOG_ERR, "%s: %m", kernel);
                exit(1);
 
 which causes the 'savecore: (null): Bad address' message seen so
 infamously as of late; I don't see how it could ever work, save 
 eliminating the (almost entirely useless, save for the mostly
 useless /minfree part) check_space logic.