Re: kern/41120: recent pullups to netbsd-4 break compilation of sys/dev/ic/rtl8169.c

["Greg A. Woods" <woods%planix.com@localhost>]

The following reply was made to PR kern/41120; it has been noted by GNATS.

From: "Greg A. Woods" <woods%planix.com@localhost>
To: NetBSD GNATS <gnats-bugs%NetBSD.org@localhost>
Cc: NetBSD Kernel Bug People <kern-bug-people%netbsd.org@localhost>,
        NetBSD GNATS Administrator <gnats-admin%NetBSD.org@localhost>
Subject: Re: kern/41120: recent pullups to netbsd-4 break compilation of 
sys/dev/ic/rtl8169.c
Date: Mon, 06 Apr 2009 17:56:08 -0400

 --pgp-sign-Multipart_Mon_Apr__6_17:56:07_2009-1
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 At Fri,  3 Apr 2009 08:45:01 +0000 (UTC), Julian Coleman 
<jdc%coris.org.uk@localhost>=
  wrote:
 Subject: Re: kern/41120: recent pullups to netbsd-4 break compilation of sy=
 s/dev/ic/rtl8169.c
 >=20
 >  It looks like this has been fixed with:
 > =20
 >    http://mail-index.NetBSD.org/source-changes/2009/04/01/msg219091.html
 > =20
 >  (some revisions were missed in the pull up).  Please could you confirm?
 
 A "cvs update" on the netbsd-4 branch since I filed the PR shows the
 only update exactly matches the changes I had to make to correct the
 problem so I'd agree the final missing change was included.
 
 >  >   BTW, it would be _REALLY_ nice if entries in CHANGES* files had
 >  >   the associated commit date(s) included in them!!!!
 > =20
 >  The dates can be discovered by using `cvs annotate` and/or `cvs log` or =
 from
 >  http://cvsweb.netbsd.org/ .  I'm not sure that adding the dates to the f=
 iles
 >  is necessary.
 
 First off, the CHANGES* file(s) is(are) available in pretty much
 uncountably more situations than where CVS access is easily available,
 even when one might be tracking "snapshots" or similar.
 
 Secondly, finding the date of any given change to a file is an extremely
 tedious and error-prone process, even by a CVS expert with full access
 to "cvs annotate" and a somewhat helpful UI such as VC in Emacs.  Indeed
 this process is a lot easier with full "cvs annotate" output for a file
 like CHANGES which is (supposed to be) only ever appended to, but so far
 as I can see this is still not very easy for anyone trying to track a
 release branch (unless they happen to understand some CVS internals).
 
 Furthermore with full CVS access it is strictly not even necessary to
 create the CHANGES* files in the first place, yet there they are.  :-)
 
 --=20
                                                Greg A. Woods
 
 +1 416 218-0098                VE3TCP          RoboHack 
<woods%robohack.ca@localhost>
 Planix, Inc. <woods%planix.com@localhost>      Secrets of the Weird 
<woods%weird.com@localhost>
 
 --pgp-sign-Multipart_Mon_Apr__6_17:56:07_2009-1
 Content-Type: application/pgp-signature
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (NetBSD)
 
 iD8DBQBJ2np3Zn1xt3i/9H8RAngFAJ0W79hRJsKo88/fNIwrgQaMgi9o+gCfaHxu
 uYYZ42Ac5+cZoy60sJdviZw=
 =nMxv
 -----END PGP SIGNATURE-----
 
 --pgp-sign-Multipart_Mon_Apr__6_17:56:07_2009-1--