NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/12605 CVS commit: src/sys/dev/pci

The following reply was made to PR kern/12605; it has been noted by GNATS.

From: "David A. Holland" <>
Subject: PR/12605 CVS commit: src/sys/dev/pci
Date: Sun, 29 Mar 2009 05:26:44 +0000

 Module Name:   src
 Committed By:  dholland
 Date:          Sun Mar 29 05:26:44 UTC 2009
 Modified Files:
        src/sys/dev/pci: if_de.c if_devar.h
 Log Message:
 Merge patch from PR 12605, which tidies up allocation of transmit DMA maps.
 Generalize it to also tidy up allocation of receive DMA maps. And change a
 few of the symbol names involved to (1) make sure all uses have been fixed
 and (2) make it clearer what's actually going on.
 Previously the driver was using DMA maps off the free list without fully
 allocating them, apparently in order to save two or three lines releasing
 them on error paths. According to the submitter of the PR (H.Saito) this
 was causing it to reuse a map already in use when under load, resulting
 in panics.
 I'm not sure if that ought to have been possible or if it reflected an
 interrupt handling bug somewhere else, but the change is an improvement
 regardless, so we'll go with it.
 Compile-tested only, but I've crosschecked the diffs and all that and it's
 a pretty noninvasive change.
 (Is anyone actually using this driver rather than tlp?)
 To generate a diff of this commit:
 cvs rdiff -u -r1.130 -r1.131 src/sys/dev/pci/if_de.c
 cvs rdiff -u -r1.50 -r1.51 src/sys/dev/pci/if_devar.h
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index