Re: kern/39034: if_ndis is broken in NetBSD-current with sources from 06/24/2008

[Geert Hendrickx <ghen%telenet.be@localhost>]

The following reply was made to PR kern/39034; it has been noted by GNATS.

From: Geert Hendrickx <ghen%telenet.be@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: is%netbsd.org@localhost
Subject: Re: kern/39034: if_ndis is broken in NetBSD-current with sources
        from 06/24/2008
Date: Thu, 26 Mar 2009 13:09:29 +0100

 --Kj7319i9nmIyA2yE
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Works for me.
 
 Here is a version of the patch for NetBSD 5.0.
 
        Geert
 
 
 --Kj7319i9nmIyA2yE
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="if_ndis_netbsd5.patch"
 
 Index: if_ndis.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/if_ndis/if_ndis.c,v
 retrieving revision 1.18
 diff -u -r1.18 if_ndis.c
 --- if_ndis.c  8 Apr 2008 06:12:21 -0000       1.18
 +++ if_ndis.c  26 Mar 2009 12:06:59 -0000
 @@ -332,7 +332,7 @@
                error = ndis_set_info(sc, OID_GEN_CURRENT_PACKET_FILTER,
                    &sc->ndis_filter, &len);
          if (error) {
 -              aprint_error_dev(sc->ndif_dev, "set filter failed: %d\n", 
 +              aprint_error_dev(sc->ndis_dev, "set filter failed: %d\n", 
                             error);
          }
                return;
 @@ -693,7 +693,7 @@
        }
  
        /* Tell the user what version of the API the driver is using. */
 -      aprint_normal_dev(&sc->ndis_dev, "NDIS API version: %d.%d\n",
 +      aprint_normal_dev(sc->ndis_dev, "NDIS API version: %d.%d\n",
                      sc->ndis_chars->nmc_version_major,
                      sc->ndis_chars->nmc_version_minor);
  
 @@ -1184,7 +1184,7 @@
  #endif
  #endif
  
 -      mtx_destroy(&sc->ndis_mtx);
 +      /* mtx_destroy(&sc->ndis_mtx); */
  
        return(0);
  }
 @@ -2599,7 +2599,7 @@
                        error = ifmedia_ioctl(ifp, ifr, &sc->ifmedia, command);
                break;
        case SIOCSIFCAP:
 -              if ((error = ether_ioctl(ifp, cmd, data)) == ENETRESET) {
 +              if ((error = ether_ioctl(ifp, command, data)) == ENETRESET) {
                        ndis_set_offload(sc);
                        error = 0;
                }
 Index: if_ndis_pci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/if_ndis/if_ndis_pci.c,v
 retrieving revision 1.10
 diff -u -r1.10 if_ndis_pci.c
 --- if_ndis_pci.c      8 Apr 2008 06:12:21 -0000       1.10
 +++ if_ndis_pci.c      26 Mar 2009 12:06:59 -0000
 @@ -653,7 +653,7 @@
        sc->ndis_rl = rl;
        sc->ndis_rescnt = rl->cprl_count;
        
 -      kthread_create(ndis_attach, (void *)sc);
 +      kthread_create(PRI_NONE, 0, NULL, ndis_attach, (void *)sc, NULL, 
"ndis_attach");
  }
  #endif /* __NetBSD__ */
  
 
 --Kj7319i9nmIyA2yE--